Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Array indent doesn't work properly inside another array #634

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

p-spacek
Copy link
Contributor

@p-spacek p-spacek commented Jan 4, 2022

What does this PR do?

Array indent doesn't work properly inside another array.

Screen.Recording.2022-01-04.at.00.33.13.mov

schema:

{
  "definitions": {
    "arrayIndent": {
      "type": "object",
      "properties": {
        "examples": {
          "type": "array",
          "items": {
            "type": "object",
            "properties": {
              "objectWithArray": {
                "type": "array",
                "items": {
                  "type": "object",
                  "required": ["item", "item2"],
                  "properties": {
                    "item": { "type": "string" },
                    "item2": { "type": "string" }
                  }
                }
              }
            }
          }
        }
      }
    }
  },
  "type": "object"
}

yaml

arrayIndent:
  examples:
    - 
arrayIndent:
  examples:
    - objectWithArray:
        - item: 
        item2: # there should be the same indent

What issues does this PR fix or reference?

no ref

Is it tested? How?

UT

@coveralls
Copy link

coveralls commented Jan 4, 2022

Coverage Status

Coverage decreased (-0.03%) to 79.558% when pulling bbbf878 on p-spacek:fix/array-indent into af7d0c3 on redhat-developer:main.

@p-spacek p-spacek requested a review from JPinkney January 4, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants